generate clientset with 1.35 code-generator#4347
Conversation
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
ray-operator/hack/update-codegen.sh
Outdated
| SCRIPT_ROOT=$(dirname "${BASH_SOURCE[0]}")/.. | ||
| ROOT_PKG=github.com/ray-project/kuberay/ray-operator | ||
| CODEGEN_PKG=$(go list -m -f "{{.Dir}}" k8s.io/code-generator) | ||
| CODEGEN_PKG=${CODEGEN_PKG:-$(cd "${SCRIPT_ROOT}"; ls -d -1 ./vendor/k8s.io/code-generator 2>/dev/null || echo ../code-generator)} |
There was a problem hiding this comment.
Could you explain the reason for this change?
There was a problem hiding this comment.
go vendor is enabled in my environment, and $(go list -m -f "{{.Dir}}" k8s.io/code-generator) return "" when go vendor is enabled. I have rollbacked this change.
There was a problem hiding this comment.
Oh cool, I think we can create an issue for go vendor users.
It seems that the CRD yamls are not updated. I have updated. |
KunWuLuan
force-pushed
the
refector/client-1.35
branch
from
6636ce6 to
7f8fad7
Compare
…esolution Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
KunWuLuan
force-pushed
the
refector/client-1.35
branch
from
7f8fad7 to
f201498
Compare
|
@win5923 Hi, I think the comments are all solved. Thanks for your comments. Can you review the code again? |
|
cc @Future-Outlier and @rueian for the final review! |
Future-Outlier
left a comment
Future-Outlier
left a comment
There was a problem hiding this comment.
I'm not sure which Kubernetes versions client-go v0.35 is compatible with,
but since the CI tests passed, LGTM.
github-project-automation
bot
moved this from can be merged
to Done
in @Future-Outlier's kuberay project
5 participants
Why are these changes needed?
Related issue number
to #4345
Checks